path: root/drivers/gpu/drm/panel/panel-novatek-nt36672a.c

// SPDX-License-Identifier: GPL-2.0+
/*
 * Copyright (C) 2020 Linaro Ltd
 * Author: Sumit Semwal <sumit.semwal@linaro.org>
 *
 * This driver is for the DSI interface to panels using the NT36672A display driver IC
 * from Novatek.
 * Currently supported are the Tianma FHD+ panels found in some Xiaomi phones, including
 * some variants of the Poco F1 phone.
 *
 * Panels using the Novatek NT37762A IC should add appropriate configuration per-panel and
 * use this driver.
 */

#include <linux/delay.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of.h>

#include <linux/gpio/consumer.h>
#include <linux/pinctrl/consumer.h>
#include <linux/regulator/consumer.h>

#include <drm/drm_device.h>
#include <drm/drm_mipi_dsi.h>
#include <drm/drm_modes.h>
#include <drm/drm_panel.h>

#include <video/mipi_display.h>

static const char * const nt36672a_regulator_names[] = {
	"vddio",
	"vddpos",
	"vddneg",
};

static unsigned long const nt36672a_regulator_enable_loads[] = {
	62000,
	100000,
	100000
};

struct nt36672a_panel_desc {
	const struct drm_display_mode *display_mode;
	const char *panel_name;

	unsigned int width_mm;
	unsigned int height_mm;

	unsigned long mode_flags;
	enum mipi_dsi_pixel_format format;
	unsigned int lanes;

	void (*send_init_cmds_1)(struct mipi_dsi_multi_context *dsi_ctx);
	void (*send_init_cmds_2)(struct mipi_dsi_multi_context *dsi_ctx);
	void (*send_deinit_cmds)(struct mipi_dsi_multi_context *dsi_ctx);
};

struct nt36672a_panel {
	struct drm_panel base;
	struct mipi_dsi_device *link;
	const struct nt36672a_panel_desc *desc;

	struct regulator_bulk_data supplies[ARRAY_SIZE(nt36672a_regulator_names)];

	struct gpio_desc *reset_gpio;
};

static inline struct nt36672a_panel *to_nt36672a_panel(struct drm_panel *panel)
{
	return container_of(panel, struct nt36672a_panel, base);
}

static void nt36672a_panel_power_off(struct drm_panel *panel)
{
	struct nt36672a_panel *pinfo = to_nt36672a_panel(panel);
	int ret;

	gpiod_set_value(pinfo->reset_gpio, 1);

	ret = regulator_bulk_disable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies);
	if (ret)
		dev_err(panel->dev, "regulator_bulk_disable failed %d\n", ret);
}

static int nt36672a_panel_unprepare(struct drm_panel *panel)
{
	struct nt36672a_panel *pinfo = to_nt36672a_panel(panel);
	struct mipi_dsi_multi_context dsi_ctx = { .dsi = pinfo->link };

	/* send off cmds */
	if (pinfo->desc->send_deinit_cmds)
		pinfo->desc->send_deinit_cmds(&dsi_ctx);

	/* Reset error to continue with display off even if send_cmds failed */
	dsi_ctx.accum_err = 0;
	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
	/* Reset error to continue power-down even if display off failed */
	dsi_ctx.accum_err = 0;

	/* 120ms delay required here as per DCS spec */
	msleep(120);

	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);

	/* 0x3C = 60ms delay */
	msleep(60);

	nt36672a_panel_power_off(panel);

	return 0;
}

static int nt36672a_panel_power_on(struct nt36672a_panel *pinfo)
{
	int ret;

	ret = regulator_bulk_enable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies);
	if (ret < 0)
		return ret;

	/*
	 * As per downstream kernel, Reset sequence of Tianma FHD panel requires the panel to
	 * be out of reset for 10ms, followed by being held in reset for 10ms. But for Android
	 * AOSP, we needed to bump it upto 200ms otherwise we get white screen sometimes.
	 * FIXME: Try to reduce this 200ms to a lesser value.
	 */
	gpiod_set_value(pinfo->reset_gpio, 1);
	msleep(200);
	gpiod_set_value(pinfo->reset_gpio, 0);
	msleep(200);

	return 0;
}

static int nt36672a_panel_prepare(struct drm_panel *panel)
{
	struct nt36672a_panel *pinfo = to_nt36672a_panel(panel);
	struct mipi_dsi_multi_context dsi_ctx = { .dsi = pinfo->link };

	dsi_ctx.accum_err = nt36672a_panel_power_on(pinfo);

	/* send first part of init cmds */
	if (pinfo->desc->send_init_cmds_1)
		pinfo->desc->send_init_cmds_1(&dsi_ctx);

	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);

	/* 0x46 = 70 ms delay */
	mipi_dsi_msleep(&dsi_ctx, 70);

	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);

	/* Send rest of the init cmds */
	if (pinfo->desc->send_init_cmds_2)
		pinfo->desc->send_init_cmds_2(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 120);

	if (dsi_ctx.accum_err < 0)
		gpiod_set_value(pinfo->reset_gpio, 0);

	return dsi_ctx.accum_err;
}

static int nt36672a_panel_get_modes(struct drm_panel *panel,
				    struct drm_connector *connector)
{
	struct nt36672a_panel *pinfo = to_nt36672a_panel(panel);
	const struct drm_display_mode *m = pinfo->desc->display_mode;
	struct drm_display_mode *mode;

	mode = drm_mode_duplicate(connector->dev, m);
	if (!mode) {
		dev_err(panel->dev, "failed to add mode %ux%u@%u\n", m->hdisplay,
			m->vdisplay, drm_mode_vrefresh(m));
		return -ENOMEM;
	}

	connector->display_info.width_mm = pinfo->desc->width_mm;
	connector->display_info.height_mm = pinfo->desc->height_mm;

	drm_mode_set_name(mode);
	drm_mode_probed_add(connector, mode);

	return 1;
}

static const struct drm_panel_funcs panel_funcs = {
	.unprepare = nt36672a_panel_unprepare,
	.prepare = nt36672a_panel_prepare,
	.get_modes = nt36672a_panel_get_modes,
};

static void tianma_fhd_video_send_init_cmds_1(struct mipi_dsi_multi_context *dsi_ctx)
{
	u8 reg;

	/* skin enhancement mode */
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x22);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x00, 0x40);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x01, 0xc0);
	for (reg = 0x02; reg <= 0x10; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x11, 0x50);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x12, 0x60);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x13, 0x70);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x14, 0x58);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x15, 0x68);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x16, 0x78);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x17, 0x77);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x18, 0x39);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x19, 0x2d);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1a, 0x2e);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1b, 0x32);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1c, 0x37);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1d, 0x3a);
	for (reg = 0x1e; reg <= 0x28; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x2d, 0x00);
	for (reg = 0x2f; reg <= 0x3b; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3d, 0x40);
	for (reg = 0x3f; reg <= 0x52; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x54, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x55, 0xfe);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x56, 0x77);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x58, 0xcd);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x59, 0xd0);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x5a, 0xd0);
	for (reg = 0x5b; reg <= 0x6f; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x50);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x70, 0x07);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x71, 0x00);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x72, 0x00);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x73, 0x00);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x74, 0x06);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x75, 0x0c);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x76, 0x03);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x77, 0x09);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x78, 0x0f);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x79, 0x68);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7a, 0x88);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7c, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7d, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7e, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7f, 0x00);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x80, 0x00);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x81, 0x00);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x83, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x84, 0x00);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x85, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x86, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x87, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x88, 0x40);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x89, 0x91);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x8a, 0x98);
	for (reg = 0x8b; reg <= 0x9f; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa0, 0x8a);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa2, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa6, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa7, 0x80);
	for (reg = 0xa9; reg <= 0xaf; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xb7, 0x76);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xb8, 0x76);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xb9, 0x05);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xba, 0x0d);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbb, 0x14);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbc, 0x0f);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbd, 0x18);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbe, 0x1f);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbf, 0x05);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc0, 0x0d);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc1, 0x14);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc2, 0x03);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc3, 0x07);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc4, 0x0a);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc5, 0xa0);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc6, 0x55);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc7, 0xff);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc8, 0x39);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc9, 0x44);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xca, 0x12);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xcd, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xdb, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xdc, 0x80);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xdd, 0x80);
	for (reg = 0xe0; reg <= 0xe4; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x80);
	for (reg = 0xe5; reg <= 0xf6; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x23);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
	/* dimming enable */
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x01, 0x84);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x05, 0x2d);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x06, 0x00);
	/* resolution 1080*2246 */
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x11, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x12, 0x7b);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x15, 0x6f);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x16, 0x0b);
	/* UI mode */
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x29, 0x0a);
	for (reg = 0x30; reg <= 0x37; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0xff);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x38, 0xfc);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x39, 0xf8);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3a, 0xf4);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3b, 0xf1);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3d, 0xee);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3f, 0xeb);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x40, 0xe8);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x41, 0xe5);
	/* STILL mode */
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x2a, 0x13);
	for (reg = 0x45; reg <= 0x4c; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0xff);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x4d, 0xed);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x4e, 0xd5);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x4f, 0xbf);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x50, 0xa6);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x51, 0x96);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x52, 0x86);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x76);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x54, 0x66);
	/* MOVING mode */
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x2b, 0x0e);
	for (reg = 0x58; reg <= 0x5f; reg++)
		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0xff);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x60, 0xf6);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x61, 0xea);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x62, 0xe1);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x63, 0xd8);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x64, 0xce);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x65, 0xc3);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x66, 0xba);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x67, 0xb3);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x25);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x05, 0x04);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x26);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1c, 0xaf);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x10);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x51, 0xff);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x24);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x55, 0x00);
}

static void tianma_fhd_video_send_init_cmds_2(struct mipi_dsi_multi_context *dsi_ctx)
{
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x24);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc3, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc4, 0x54);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x10);
}

static void tianma_fhd_video_send_deinit_cmds(struct mipi_dsi_multi_context *dsi_ctx)
{
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x24);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc3, 0x01);
	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x10);
}

static const struct drm_display_mode tianma_fhd_video_panel_default_mode = {
	.clock		= 161331,

	.hdisplay	= 1080,
	.hsync_start	= 1080 + 40,
	.hsync_end	= 1080 + 40 + 20,
	.htotal		= 1080 + 40 + 20 + 44,

	.vdisplay	= 2246,
	.vsync_start	= 2246 + 15,
	.vsync_end	= 2246 + 15 + 2,
	.vtotal		= 2246 + 15 + 2 + 8,

	.type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
};

static const struct nt36672a_panel_desc tianma_fhd_video_panel_desc = {
	.display_mode = &tianma_fhd_video_panel_default_mode,

	.width_mm = 68,
	.height_mm = 136,

	.mode_flags = MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_VIDEO
			| MIPI_DSI_MODE_VIDEO_HSE
			| MIPI_DSI_CLOCK_NON_CONTINUOUS
			| MIPI_DSI_MODE_VIDEO_BURST,
	.format = MIPI_DSI_FMT_RGB888,
	.lanes = 4,
	.send_init_cmds_1 = tianma_fhd_video_send_init_cmds_1,
	.send_init_cmds_2 = tianma_fhd_video_send_init_cmds_2,
	.send_deinit_cmds = tianma_fhd_video_send_deinit_cmds,
};

static int nt36672a_panel_add(struct nt36672a_panel *pinfo)
{
	struct device *dev = &pinfo->link->dev;
	int i, ret;

	for (i = 0; i < ARRAY_SIZE(pinfo->supplies); i++) {
		pinfo->supplies[i].supply = nt36672a_regulator_names[i];
		pinfo->supplies[i].init_load_uA = nt36672a_regulator_enable_loads[i];
	}

	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pinfo->supplies),
				      pinfo->supplies);
	if (ret < 0)
		return dev_err_probe(dev, ret, "failed to get regulators\n");

	pinfo->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
	if (IS_ERR(pinfo->reset_gpio))
		return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio),
				     "failed to get reset gpio from DT\n");

	ret = drm_panel_of_backlight(&pinfo->base);
	if (ret)
		return dev_err_probe(dev, ret, "Failed to get backlight\n");

	drm_panel_add(&pinfo->base);

	return 0;
}

static int nt36672a_panel_probe(struct mipi_dsi_device *dsi)
{
	struct nt36672a_panel *pinfo;
	const struct nt36672a_panel_desc *desc;
	int err;

	pinfo = devm_drm_panel_alloc(&dsi->dev, __typeof(*pinfo), base,
				     &panel_funcs, DRM_MODE_CONNECTOR_DSI);

	if (IS_ERR(pinfo))
		return PTR_ERR(pinfo);

	desc = of_device_get_match_data(&dsi->dev);
	dsi->mode_flags = desc->mode_flags;
	dsi->format = desc->format;
	dsi->lanes = desc->lanes;
	pinfo->desc = desc;
	pinfo->link = dsi;

	mipi_dsi_set_drvdata(dsi, pinfo);

	err = nt36672a_panel_add(pinfo);
	if (err < 0)
		return err;

	err = mipi_dsi_attach(dsi);
	if (err < 0) {
		drm_panel_remove(&pinfo->base);
		return err;
	}

	return 0;
}

static void nt36672a_panel_remove(struct mipi_dsi_device *dsi)
{
	struct nt36672a_panel *pinfo = mipi_dsi_get_drvdata(dsi);
	int err;

	err = mipi_dsi_detach(dsi);
	if (err < 0)
		dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);

	drm_panel_remove(&pinfo->base);
}

static const struct of_device_id tianma_fhd_video_of_match[] = {
	{ .compatible = "tianma,fhd-video", .data = &tianma_fhd_video_panel_desc },
	{ },
};
MODULE_DEVICE_TABLE(of, tianma_fhd_video_of_match);

static struct mipi_dsi_driver nt36672a_panel_driver = {
	.driver = {
		.name = "panel-tianma-nt36672a",
		.of_match_table = tianma_fhd_video_of_match,
	},
	.probe = nt36672a_panel_probe,
	.remove = nt36672a_panel_remove,
};
module_mipi_dsi_driver(nt36672a_panel_driver);

MODULE_AUTHOR("Sumit Semwal <sumit.semwal@linaro.org>");
MODULE_DESCRIPTION("NOVATEK NT36672A based MIPI-DSI LCD panel driver");
MODULE_LICENSE("GPL");