summaryrefslogtreecommitdiffstats
path: root/tools/perf/util/parse-regs-options.c
diff options
context:
space:
mode:
authorShivank Garg <shivankg@amd.com>2026-08-22 19:22:05 +0000
committerVinod Koul <vkoul@kernel.org>2026-09-09 17:51:44 +0530
commite873c74132f0c5f1452816cd9bb26208f0bba1e1 (patch)
treecc1ce1567f5b982359331863ebd9da38741f8d2e /tools/perf/util/parse-regs-options.c
downloadlinux-stable-e873c74132f0c5f1452816cd9bb26208f0bba1e1.tar.gz
linux-stable-e873c74132f0c5f1452816cd9bb26208f0bba1e1.zip
dmaengine: fix use-after-free in dma_chan_put() and dma_release_channel()grafted
When dma_device_put() drops the last reference on chan->device->ref, dma_device_release() runs and may free the dma_device along with its channels. dma_chan_put() then still reads chan->device->owner via dma_chan_to_owner() for the trailing module_put(). KASAN catches it: slab-use-after-free in dma_chan_put+0x3e6/0x4c0 Read of size 8 by task insmod/6319 Freed by task 6319: kfree+0x225/0x470 dma_chan_put+0x395/0x4c0 dmaengine_put+0xf8/0x160 Cache the module owner in dma_chan_put() before the put so the trailing module_put() does not need chan->device. Fixes: 8ad342a86359 ("dmaengine: Add reference counting to dma_device struct") Suggested-by: Sashiko <sashiko-bot@kernel.org> Link: https://sashiko.dev/#/patchset/20260518-dmaengine-kref-fix-v1-1-4d6125048fb7@amd.com Reviewed-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Logan Gunthorpe <logang@deltatee.com> Signed-off-by: Shivank Garg <shivankg@amd.com> Link: https://patch.msgid.link/20260822-dmaengine-kref-fix-v5-3-d4a4ee47d927@amd.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'tools/perf/util/parse-regs-options.c')
-rw-r--r--tools/perf/util/parse-regs-options.c124
1 files changed, 124 insertions, 0 deletions
diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c
new file mode 100644
index 000000000..c93c2f0c8
--- /dev/null
+++ b/tools/perf/util/parse-regs-options.c
@@ -0,0 +1,124 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <stdbool.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <string.h>
+#include <stdio.h>
+#include "util/debug.h"
+#include <dwarf-regs.h>
+#include <subcmd/parse-options.h>
+#include "util/perf_regs.h"
+#include "util/parse-regs-options.h"
+
+static void list_perf_regs(FILE *fp, uint64_t mask)
+{
+ const char *last_name = NULL;
+
+ fprintf(fp, "available registers: ");
+ for (int reg = 0; reg < 64; reg++) {
+ const char *name;
+
+ if (((1ULL << reg) & mask) == 0)
+ continue;
+
+ name = perf_reg_name(reg, EM_HOST, EF_HOST);
+ if (name && (!last_name || strcmp(last_name, name)))
+ fprintf(fp, "%s%s", reg > 0 ? " " : "", name);
+ last_name = name;
+ }
+ fputc('\n', fp);
+}
+
+static uint64_t name_to_perf_reg_mask(const char *to_match, uint64_t mask)
+{
+ uint64_t reg_mask = 0;
+
+ for (int reg = 0; reg < 64; reg++) {
+ const char *name;
+
+ if (((1ULL << reg) & mask) == 0)
+ continue;
+
+ name = perf_reg_name(reg, EM_HOST, EF_HOST);
+ if (!name)
+ continue;
+
+ if (!strcasecmp(to_match, name))
+ reg_mask |= 1ULL << reg;
+ }
+ return reg_mask;
+}
+
+static int
+__parse_regs(const struct option *opt, const char *str, int unset, bool intr)
+{
+ uint64_t *mode = (uint64_t *)opt->value;
+ char *s, *os = NULL, *p;
+ int ret = -1;
+ uint64_t mask;
+
+ if (unset)
+ return 0;
+
+ /*
+ * cannot set it twice
+ */
+ if (*mode)
+ return -1;
+
+ mask = intr ? perf_intr_reg_mask(EM_HOST) : perf_user_reg_mask(EM_HOST);
+
+ /* str may be NULL in case no arg is passed to -I */
+ if (!str) {
+ *mode = mask;
+ return 0;
+ }
+
+ /* because str is read-only */
+ s = os = strdup(str);
+ if (!s)
+ return -1;
+
+ for (;;) {
+ uint64_t reg_mask;
+
+ p = strchr(s, ',');
+ if (p)
+ *p = '\0';
+
+ if (!strcmp(s, "?")) {
+ list_perf_regs(stderr, mask);
+ goto error;
+ }
+
+ reg_mask = name_to_perf_reg_mask(s, mask);
+ if (reg_mask == 0) {
+ ui__warning("Unknown register \"%s\", check man page or run \"perf record %s?\"\n",
+ s, intr ? "-I" : "--user-regs=");
+ goto error;
+ }
+ *mode |= reg_mask;
+
+ if (!p)
+ break;
+
+ s = p + 1;
+ }
+ ret = 0;
+
+error:
+ free(os);
+ return ret;
+}
+
+int
+parse_user_regs(const struct option *opt, const char *str, int unset)
+{
+ return __parse_regs(opt, str, unset, false);
+}
+
+int
+parse_intr_regs(const struct option *opt, const char *str, int unset)
+{
+ return __parse_regs(opt, str, unset, true);
+}