diff options
| author | Shivank Garg <shivankg@amd.com> | 2026-08-22 19:22:05 +0000 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2026-09-09 17:51:44 +0530 |
| commit | e873c74132f0c5f1452816cd9bb26208f0bba1e1 (patch) | |
| tree | cc1ce1567f5b982359331863ebd9da38741f8d2e /lib/compat_audit.c | |
| download | linux-stable-e873c74132f0c5f1452816cd9bb26208f0bba1e1.tar.gz linux-stable-e873c74132f0c5f1452816cd9bb26208f0bba1e1.zip | |
dmaengine: fix use-after-free in dma_chan_put() and dma_release_channel()grafted
When dma_device_put() drops the last reference on chan->device->ref,
dma_device_release() runs and may free the dma_device along with its
channels.
dma_chan_put() then still reads chan->device->owner via
dma_chan_to_owner() for the trailing module_put(). KASAN catches it:
slab-use-after-free in dma_chan_put+0x3e6/0x4c0
Read of size 8 by task insmod/6319
Freed by task 6319:
kfree+0x225/0x470
dma_chan_put+0x395/0x4c0
dmaengine_put+0xf8/0x160
Cache the module owner in dma_chan_put() before the put so the trailing
module_put() does not need chan->device.
Fixes: 8ad342a86359 ("dmaengine: Add reference counting to dma_device struct")
Suggested-by: Sashiko <sashiko-bot@kernel.org>
Link: https://sashiko.dev/#/patchset/20260518-dmaengine-kref-fix-v1-1-4d6125048fb7@amd.com
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Shivank Garg <shivankg@amd.com>
Link: https://patch.msgid.link/20260822-dmaengine-kref-fix-v5-3-d4a4ee47d927@amd.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'lib/compat_audit.c')
| -rw-r--r-- | lib/compat_audit.c | 56 |
1 files changed, 56 insertions, 0 deletions
diff --git a/lib/compat_audit.c b/lib/compat_audit.c new file mode 100644 index 000000000..fee1dfccd --- /dev/null +++ b/lib/compat_audit.c @@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <linux/init.h> +#include <linux/types.h> +#include <linux/audit_arch.h> +#include <asm/unistd32.h> + +unsigned int compat_dir_class[] = { +#include <asm-generic/audit_dir_write.h> +~0U +}; + +unsigned int compat_read_class[] = { +#include <asm-generic/audit_read.h> +~0U +}; + +unsigned int compat_write_class[] = { +#include <asm-generic/audit_write.h> +~0U +}; + +unsigned int compat_chattr_class[] = { +#include <asm-generic/audit_change_attr.h> +~0U +}; + +unsigned int compat_signal_class[] = { +#include <asm-generic/audit_signal.h> +~0U +}; + +int audit_classify_compat_syscall(int abi, unsigned int syscall) +{ + switch (syscall) { +#ifdef __NR_open + case __NR_open: + return AUDITSC_OPEN; +#endif +#ifdef __NR_openat + case __NR_openat: + return AUDITSC_OPENAT; +#endif +#ifdef __NR_socketcall + case __NR_socketcall: + return AUDITSC_SOCKETCALL; +#endif + case __NR_execve: + return AUDITSC_EXECVE; +#ifdef __NR_openat2 + case __NR_openat2: + return AUDITSC_OPENAT2; +#endif + default: + return AUDITSC_COMPAT; + } +} |
