openrisc: fix arbitrary kernel memory access via or1k_atomic syscallgrafted

sys_or1k_atomic() (syscall 244 in the "or1k" ABI) takes two user
pointers, v1 and v2, and swaps the words they point to in hand-written
assembly.

    l.lwz   r29,0(r4)
    l.lwz   r27,0(r5)
    l.sw    0(r4),r27
    l.sw    0(r5),r29

The pointers are not checked with access_ok(). The four memory
accesses also have no exception table entries.

A caller passes a kernel address as either pointer, and the syscall
reads from and writes to it directly.

This gives an unprivileged process a kernel read/write primitive. It
overwrites kernel data such as the sys_call_table, gaining code
execution in kernel context.

Check both pointers before entering the critical section. Add fixups
for the four memory accesses so faults on valid but unmapped user
addresses return -EFAULT.

[shorne@gmail.com: fix comment style]
Fixes: 9d02a4283e9c ("OpenRISC: Boot code")
Cc: stable@vger.kernel.org
Signed-off-by: Ali Ahmet Memis <ali@iusegentoo.com>
Signed-off-by: Stafford Horne <shorne@gmail.com>

1 files changed, 42 insertions, 0 deletions

diff --git a/Documentation/dev-tools/index.rst b/Documentation/dev-tools/index.rst
new file mode 100644
index 000000000..59cbb77b3
--- /dev/null
+++ b/Documentation/dev-tools/index.rst
@@ -0,0 +1,42 @@
+================================
+Development tools for the kernel
+================================
+
+This document is a collection of documents about development tools that can
+be used to work on the kernel. For now, the documents have been pulled
+together without any significant effort to integrate them into a coherent
+whole; patches welcome!
+
+A brief overview of testing-specific tools can be found in
+Documentation/dev-tools/testing-overview.rst
+
+Tools that are specific to debugging can be found in
+Documentation/process/debugging/index.rst
+
+.. toctree::
+   :caption: Table of contents
+   :maxdepth: 2
+
+   testing-overview
+   checkpatch
+   clang-format
+   coccinelle
+   context-analysis
+   sparse
+   kcov
+   gcov
+   kasan
+   kmsan
+   ubsan
+   kmemleak
+   kcsan
+   lkmm/index
+   kfence
+   kselftest
+   kunit/index
+   ktap
+   checkuapi
+   gpio-sloppy-logic-analyzer
+   autofdo
+   propeller
+   container