From 34ff636f322c6d5e4f0a52338fa63a7dff09a495 Mon Sep 17 00:00:00 2001 From: Joel Fernandes Date: Sat, 18 Jul 2026 13:15:36 -0400 Subject: scftorture: Count single_rpc offline failures in statistics output scf_torture_stats_print() aggregates each invoker thread's counters into a local scf_statistics structure before printing, but the n_single_rpc_ofl field is missing from the aggregation loop. As a result, the "single_rpc_ofl" value printed in the statistics line is always zero, even when smp_call_function_single() invocations for the RPC test have failed due to offline CPUs and been counted by the invoker threads. Add the missing accumulation so that the printed value reflects the actual counts. Signed-off-by: Joel Fernandes Signed-off-by: Paul E. McKenney --- tools/perf/ui/util.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 tools/perf/ui/util.c (limited to 'tools/perf/ui/util.c') diff --git a/tools/perf/ui/util.c b/tools/perf/ui/util.c new file mode 100644 index 000000000..1d38ddf01 --- /dev/null +++ b/tools/perf/ui/util.c @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "util.h" +#include "../util/debug.h" +#include + +/* + * Default error logging functions + */ +static int perf_stdio__error(const char *format, va_list args) +{ + fprintf(stderr, "Error:\n"); + vfprintf(stderr, format, args); + return 0; +} + +static int perf_stdio__warning(const char *format, va_list args) +{ + if (quiet) + return 0; + + fprintf(stderr, "Warning:\n"); + vfprintf(stderr, format, args); + return 0; +} + +static struct perf_error_ops default_eops = +{ + .error = perf_stdio__error, + .warning = perf_stdio__warning, +}; + +static struct perf_error_ops *perf_eops = &default_eops; + + +int ui__error(const char *format, ...) +{ + int ret; + va_list args; + + va_start(args, format); + ret = perf_eops->error(format, args); + va_end(args); + + return ret; +} + +int ui__warning(const char *format, ...) +{ + int ret; + va_list args; + if (quiet) + return 0; + + va_start(args, format); + ret = perf_eops->warning(format, args); + va_end(args); + + return ret; +} + +/** + * perf_error__register - Register error logging functions + * @eops: The pointer to error logging function struct + * + * Register UI-specific error logging functions. Before calling this, + * other logging functions should be unregistered, if any. + */ +int perf_error__register(struct perf_error_ops *eops) +{ + if (perf_eops != &default_eops) + return -1; + + perf_eops = eops; + return 0; +} + +/** + * perf_error__unregister - Unregister error logging functions + * @eops: The pointer to error logging function struct + * + * Unregister already registered error logging functions. + */ +int perf_error__unregister(struct perf_error_ops *eops) +{ + if (perf_eops != eops) + return -1; + + perf_eops = &default_eops; + return 0; +} -- cgit v1.3.1