From ff917923f4fb9c83717ba135ee47d7e4c1567bb7 Mon Sep 17 00:00:00 2001 From: Muhammad Bilal Date: Tue, 28 Jul 2026 17:54:55 +0500 Subject: staging: rtl8723bs: fix OOB read in rtw_action_frame_parse() rtw_action_frame_parse() takes a frame_len parameter but never actually checks it before indexing into the frame body: const u8 *frame_body = frame + sizeof(struct ieee80211_hdr_3addr); ... c = frame_body[0]; ... a = frame_body[1]; frame_body already points 24 bytes (sizeof(struct ieee80211_hdr_3addr)) into frame, so reading frame_body[0] and frame_body[1] requires frame_len >= 26. A management action frame shorter than that (e.g. exactly 24 bytes, the minimum a malicious peer can send) causes a 1-2 byte out-of-bounds read. This is reachable from rtw_cfg80211_monitor_if_xmit_entry() and cfg80211_rtw_mgmt_tx() in ioctl_cfg80211.c, both of which pass attacker/user-influenced frame buffers and lengths straight through. Add the missing length check before frame_body is dereferenced. Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal Link: https://patch.msgid.link/20260728125456.32359-3-meatuni001@gmail.com Signed-off-by: Greg Kroah-Hartman --- lib/compat_audit.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 lib/compat_audit.c (limited to 'lib/compat_audit.c') diff --git a/lib/compat_audit.c b/lib/compat_audit.c new file mode 100644 index 000000000..fee1dfccd --- /dev/null +++ b/lib/compat_audit.c @@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include +#include +#include + +unsigned int compat_dir_class[] = { +#include +~0U +}; + +unsigned int compat_read_class[] = { +#include +~0U +}; + +unsigned int compat_write_class[] = { +#include +~0U +}; + +unsigned int compat_chattr_class[] = { +#include +~0U +}; + +unsigned int compat_signal_class[] = { +#include +~0U +}; + +int audit_classify_compat_syscall(int abi, unsigned int syscall) +{ + switch (syscall) { +#ifdef __NR_open + case __NR_open: + return AUDITSC_OPEN; +#endif +#ifdef __NR_openat + case __NR_openat: + return AUDITSC_OPENAT; +#endif +#ifdef __NR_socketcall + case __NR_socketcall: + return AUDITSC_SOCKETCALL; +#endif + case __NR_execve: + return AUDITSC_EXECVE; +#ifdef __NR_openat2 + case __NR_openat2: + return AUDITSC_OPENAT2; +#endif + default: + return AUDITSC_COMPAT; + } +} -- cgit v1.3.1