From 27600805e62f800bacf990354632eae4e487d34c Mon Sep 17 00:00:00 2001
From: Yazen Ghannam <yazen.ghannam@amd.com>
Date: Thu, 3 Sep 2026 10:43:25 -0500
Subject: x86/amd_node: Fix PCI device reference counting in amd_smn_init()

The local "root" pointer is a temporary variable used during the device
search. Therefore, refcount related to the search iterators should be cleaned
up after the search is complete.

Use the __free() cleanup macro to ensure the refcount is decremented when the
temporary pointer goes out of scope.

Additionally, increment the refcount when caching a root pointer. This ensures
the in-use refcount is separate from the temporary search refcounting.

Finally, drop the redundant "root = NULL" before the second search loop. The
pci_get_class() iterator always decrements the refcount of its "from"
argument, so the first loop can only fall through with "root" already NULL.

Fixes: 0a4b61d9c2e4 ("x86/amd_node: Fix AMD root device caching")
Closes: https://sashiko.dev/#/patchset/20260806160159.230453-1-jason.andryuk%40amd.com
Reported-by: Sashiko <sashiko-bot@kernel.org>
Assisted-by: LLM
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Cc: <stable@kernel.org>
Link: https://patch.msgid.link/20260903154325.74343-1-yazen.ghannam@amd.com
---
 lib/compat_audit.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 lib/compat_audit.c

(limited to 'lib/compat_audit.c')

diff --git a/lib/compat_audit.c b/lib/compat_audit.c
new file mode 100644
index 000000000..fee1dfccd
--- /dev/null
+++ b/lib/compat_audit.c
@@ -0,0 +1,56 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <linux/init.h>
+#include <linux/types.h>
+#include <linux/audit_arch.h>
+#include <asm/unistd32.h>
+
+unsigned int compat_dir_class[] = {
+#include <asm-generic/audit_dir_write.h>
+~0U
+};
+
+unsigned int compat_read_class[] = {
+#include <asm-generic/audit_read.h>
+~0U
+};
+
+unsigned int compat_write_class[] = {
+#include <asm-generic/audit_write.h>
+~0U
+};
+
+unsigned int compat_chattr_class[] = {
+#include <asm-generic/audit_change_attr.h>
+~0U
+};
+
+unsigned int compat_signal_class[] = {
+#include <asm-generic/audit_signal.h>
+~0U
+};
+
+int audit_classify_compat_syscall(int abi, unsigned int syscall)
+{
+	switch (syscall) {
+#ifdef __NR_open
+	case __NR_open:
+		return AUDITSC_OPEN;
+#endif
+#ifdef __NR_openat
+	case __NR_openat:
+		return AUDITSC_OPENAT;
+#endif
+#ifdef __NR_socketcall
+	case __NR_socketcall:
+		return AUDITSC_SOCKETCALL;
+#endif
+	case __NR_execve:
+		return AUDITSC_EXECVE;
+#ifdef __NR_openat2
+	case __NR_openat2:
+		return AUDITSC_OPENAT2;
+#endif
+	default:
+		return AUDITSC_COMPAT;
+	}
+}
-- 
cgit v1.3.1