From 93de2a6a4b91b72607136dd656edf03fb399d27f Mon Sep 17 00:00:00 2001 From: Sean Christopherson Date: Wed, 23 Sep 2026 09:37:21 -0700 Subject: KVM: SEV: Do cache maintenance on the source VM during intra-host migration Manually perform cache maintenance on the source VM during intra-host migration to ensure no stale data is left in CPU caches after the VM is destroyed. Because the source VM is "converted" to a non-SEV VM, KVM's memory reclaim flows won't trigger cache maintenance, e.g. when all guest memory is reclaimed in response to detaching from the mmu_notifier. Note, relying on the destination VM to do cache maintenance isn't an option as KVM doesn't require identical guest memory configurations, i.e. the source VM may have access to memory that the destination VM does not. Enforcing equivalent memory configurations is infeasible, as it would require a *deep* comparison of memslots, e.g. to verify that not only are the memslot identical, but what the memslots point at is also identical. Fixes: b56639318bb2 ("KVM: SEV: Add support for SEV intra host migration") Cc: stable@vger.kernel.org Reported-by: Stefan Teodorescu Signed-off-by: Sean Christopherson Message-ID: <20260923163721.1584779-3-seanjc@google.com> Signed-off-by: Paolo Bonzini --- lib/atomic64.c | 207 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 207 insertions(+) create mode 100644 lib/atomic64.c (limited to 'lib/atomic64.c') diff --git a/lib/atomic64.c b/lib/atomic64.c new file mode 100644 index 000000000..1a72bba36 --- /dev/null +++ b/lib/atomic64.c @@ -0,0 +1,207 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Generic implementation of 64-bit atomics using spinlocks, + * useful on processors that don't have 64-bit atomic instructions. + * + * Copyright © 2009 Paul Mackerras, IBM Corp. + */ +#include +#include +#include +#include +#include +#include + +/* + * We use a hashed array of spinlocks to provide exclusive access + * to each atomic64_t variable. Since this is expected to used on + * systems with small numbers of CPUs (<= 4 or so), we use a + * relatively small array of 16 spinlocks to avoid wasting too much + * memory on the spinlock array. + */ +#define NR_LOCKS 16 + +/* + * Ensure each lock is in a separate cacheline. + */ +static union { + arch_spinlock_t lock; + char pad[L1_CACHE_BYTES]; +} atomic64_lock[NR_LOCKS] __cacheline_aligned_in_smp = { + [0 ... (NR_LOCKS - 1)] = { + .lock = __ARCH_SPIN_LOCK_UNLOCKED, + }, +}; + +static inline arch_spinlock_t *lock_addr(const atomic64_t *v) +{ + unsigned long addr = (unsigned long) v; + + addr >>= L1_CACHE_SHIFT; + addr ^= (addr >> 8) ^ (addr >> 16); + return &atomic64_lock[addr & (NR_LOCKS - 1)].lock; +} + +s64 generic_atomic64_read(const atomic64_t *v) +{ + unsigned long flags; + arch_spinlock_t *lock = lock_addr(v); + s64 val; + + local_irq_save(flags); + arch_spin_lock(lock); + val = v->counter; + arch_spin_unlock(lock); + local_irq_restore(flags); + return val; +} +EXPORT_SYMBOL(generic_atomic64_read); + +void generic_atomic64_set(atomic64_t *v, s64 i) +{ + unsigned long flags; + arch_spinlock_t *lock = lock_addr(v); + + local_irq_save(flags); + arch_spin_lock(lock); + v->counter = i; + arch_spin_unlock(lock); + local_irq_restore(flags); +} +EXPORT_SYMBOL(generic_atomic64_set); + +#define ATOMIC64_OP(op, c_op) \ +void generic_atomic64_##op(s64 a, atomic64_t *v) \ +{ \ + unsigned long flags; \ + arch_spinlock_t *lock = lock_addr(v); \ + \ + local_irq_save(flags); \ + arch_spin_lock(lock); \ + v->counter c_op a; \ + arch_spin_unlock(lock); \ + local_irq_restore(flags); \ +} \ +EXPORT_SYMBOL(generic_atomic64_##op); + +#define ATOMIC64_OP_RETURN(op, c_op) \ +s64 generic_atomic64_##op##_return(s64 a, atomic64_t *v) \ +{ \ + unsigned long flags; \ + arch_spinlock_t *lock = lock_addr(v); \ + s64 val; \ + \ + local_irq_save(flags); \ + arch_spin_lock(lock); \ + val = (v->counter c_op a); \ + arch_spin_unlock(lock); \ + local_irq_restore(flags); \ + return val; \ +} \ +EXPORT_SYMBOL(generic_atomic64_##op##_return); + +#define ATOMIC64_FETCH_OP(op, c_op) \ +s64 generic_atomic64_fetch_##op(s64 a, atomic64_t *v) \ +{ \ + unsigned long flags; \ + arch_spinlock_t *lock = lock_addr(v); \ + s64 val; \ + \ + local_irq_save(flags); \ + arch_spin_lock(lock); \ + val = v->counter; \ + v->counter c_op a; \ + arch_spin_unlock(lock); \ + local_irq_restore(flags); \ + return val; \ +} \ +EXPORT_SYMBOL(generic_atomic64_fetch_##op); + +#define ATOMIC64_OPS(op, c_op) \ + ATOMIC64_OP(op, c_op) \ + ATOMIC64_OP_RETURN(op, c_op) \ + ATOMIC64_FETCH_OP(op, c_op) + +ATOMIC64_OPS(add, +=) +ATOMIC64_OPS(sub, -=) + +#undef ATOMIC64_OPS +#define ATOMIC64_OPS(op, c_op) \ + ATOMIC64_OP(op, c_op) \ + ATOMIC64_FETCH_OP(op, c_op) + +ATOMIC64_OPS(and, &=) +ATOMIC64_OPS(or, |=) +ATOMIC64_OPS(xor, ^=) + +#undef ATOMIC64_OPS +#undef ATOMIC64_FETCH_OP +#undef ATOMIC64_OP + +s64 generic_atomic64_dec_if_positive(atomic64_t *v) +{ + unsigned long flags; + arch_spinlock_t *lock = lock_addr(v); + s64 val; + + local_irq_save(flags); + arch_spin_lock(lock); + val = v->counter - 1; + if (val >= 0) + v->counter = val; + arch_spin_unlock(lock); + local_irq_restore(flags); + return val; +} +EXPORT_SYMBOL(generic_atomic64_dec_if_positive); + +s64 generic_atomic64_cmpxchg(atomic64_t *v, s64 o, s64 n) +{ + unsigned long flags; + arch_spinlock_t *lock = lock_addr(v); + s64 val; + + local_irq_save(flags); + arch_spin_lock(lock); + val = v->counter; + if (val == o) + v->counter = n; + arch_spin_unlock(lock); + local_irq_restore(flags); + return val; +} +EXPORT_SYMBOL(generic_atomic64_cmpxchg); + +s64 generic_atomic64_xchg(atomic64_t *v, s64 new) +{ + unsigned long flags; + arch_spinlock_t *lock = lock_addr(v); + s64 val; + + local_irq_save(flags); + arch_spin_lock(lock); + val = v->counter; + v->counter = new; + arch_spin_unlock(lock); + local_irq_restore(flags); + return val; +} +EXPORT_SYMBOL(generic_atomic64_xchg); + +s64 generic_atomic64_fetch_add_unless(atomic64_t *v, s64 a, s64 u) +{ + unsigned long flags; + arch_spinlock_t *lock = lock_addr(v); + s64 val; + + local_irq_save(flags); + arch_spin_lock(lock); + val = v->counter; + if (val != u) + v->counter += a; + arch_spin_unlock(lock); + local_irq_restore(flags); + + return val; +} +EXPORT_SYMBOL(generic_atomic64_fetch_add_unless); -- cgit v1.3.1