From 7e61560628d17ea6b1d8ee370f6d42694cff8758 Mon Sep 17 00:00:00 2001 From: Ulises Mendez Martinez Date: Fri, 4 Sep 2026 15:07:09 +0000 Subject: objtool: Validate disassembler headers in libopcodes probe commit 3f2de814c059 ("objtool: Fix libopcodes linking with static libraries") tested for libopcodes availability by linking a test snippet with a forward declaration of disassemble_init_for_target(). However, testing symbol linkage with an extern declaration only verifies the presence of the library (.so/.a) and bypasses checking for development headers (binutils-dev). On systems where libopcodes is present without development headers installed, the probe succeeds, enabling BUILD_DISAS. Subsequent compilation of objtool then fails: fatal error: 'bfd.h' file not found 113 | #include Additionally, the probe invokes $(HOSTCC) without $(HOSTCFLAGS), ignoring any sysroot or include flags specified for the host compiler. Fix this by including and directly in the test snippet, passing $(HOSTCFLAGS) so host compiler options are respected, and defining PACKAGE="objtool" to satisfy the configuration check in . Fixes: 3f2de814c059 ("objtool: Fix libopcodes linking with static libraries") Fixes: 436326bc525d ("objtool: fix build failure due to missing libopcodes check") Reported-by: Alice Ryhl Assisted-by: Antigravity:Gemini-Next Signed-off-by: Ulises Mendez Martinez Link: https://patch.msgid.link/20260904150710.2997558-1-umendez@google.com Signed-off-by: Josh Poimboeuf --- drivers/video/fbdev/q40fb.c | 151 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 151 insertions(+) create mode 100644 drivers/video/fbdev/q40fb.c (limited to 'drivers/video/fbdev/q40fb.c') diff --git a/drivers/video/fbdev/q40fb.c b/drivers/video/fbdev/q40fb.c new file mode 100644 index 000000000..1ff8fa176 --- /dev/null +++ b/drivers/video/fbdev/q40fb.c @@ -0,0 +1,151 @@ +/* + * linux/drivers/video/q40fb.c -- Q40 frame buffer device + * + * Copyright (C) 2001 + * + * Richard Zidlicky + * + * This file is subject to the terms and conditions of the GNU General Public + * License. See the file COPYING in the main directory of this archive for + * more details. + */ + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#define Q40_PHYS_SCREEN_ADDR 0xFE800000 + +static struct fb_fix_screeninfo q40fb_fix = { + .id = "Q40", + .smem_len = 1024*1024, + .type = FB_TYPE_PACKED_PIXELS, + .visual = FB_VISUAL_TRUECOLOR, + .line_length = 1024*2, + .accel = FB_ACCEL_NONE, +}; + +static const struct fb_var_screeninfo q40fb_var = { + .xres = 1024, + .yres = 512, + .xres_virtual = 1024, + .yres_virtual = 512, + .bits_per_pixel = 16, + .red = {6, 5, 0}, + .green = {11, 5, 0}, + .blue = {0, 6, 0}, + .activate = FB_ACTIVATE_NOW, + .height = 230, + .width = 300, + .vmode = FB_VMODE_NONINTERLACED, +}; + +static int q40fb_setcolreg(unsigned regno, unsigned red, unsigned green, + unsigned blue, unsigned transp, + struct fb_info *info) +{ + /* + * Set a single color register. The values supplied have a 16 bit + * magnitude. + * Return != 0 for invalid regno. + */ + + if (regno > 255) + return 1; + red>>=11; + green>>=11; + blue>>=10; + + if (regno < 16) { + ((u32 *)info->pseudo_palette)[regno] = ((red & 31) <<6) | + ((green & 31) << 11) | + (blue & 63); + } + return 0; +} + +static const struct fb_ops q40fb_ops = { + .owner = THIS_MODULE, + FB_DEFAULT_IOMEM_OPS, + .fb_setcolreg = q40fb_setcolreg, +}; + +static int q40fb_probe(struct platform_device *dev) +{ + struct fb_info *info; + + if (!MACH_IS_Q40) + return -ENXIO; + + /* mapped in q40/config.c */ + q40fb_fix.smem_start = Q40_PHYS_SCREEN_ADDR; + + info = framebuffer_alloc(sizeof(u32) * 16, &dev->dev); + if (!info) + return -ENOMEM; + + info->var = q40fb_var; + info->fix = q40fb_fix; + info->fbops = &q40fb_ops; + info->pseudo_palette = info->par; + info->par = NULL; + info->screen_base = (char *) q40fb_fix.smem_start; + + if (fb_alloc_cmap(&info->cmap, 256, 0) < 0) { + framebuffer_release(info); + return -ENOMEM; + } + + master_outb(3, DISPLAY_CONTROL_REG); + + if (register_framebuffer(info) < 0) { + printk(KERN_ERR "Unable to register Q40 frame buffer\n"); + fb_dealloc_cmap(&info->cmap); + framebuffer_release(info); + return -EINVAL; + } + + fb_info(info, "Q40 frame buffer alive and kicking !\n"); + return 0; +} + +static struct platform_driver q40fb_driver = { + .probe = q40fb_probe, + .driver = { + .name = "q40fb", + }, +}; + +static struct platform_device q40fb_device = { + .name = "q40fb", +}; + +static int __init q40fb_init(void) +{ + int ret = 0; + + if (fb_get_options("q40fb", NULL)) + return -ENODEV; + + ret = platform_driver_register(&q40fb_driver); + + if (!ret) { + ret = platform_device_register(&q40fb_device); + if (ret) + platform_driver_unregister(&q40fb_driver); + } + return ret; +} + +module_init(q40fb_init); +MODULE_LICENSE("GPL"); -- cgit v1.3.1