From e873c74132f0c5f1452816cd9bb26208f0bba1e1 Mon Sep 17 00:00:00 2001 From: Shivank Garg Date: Sat, 22 Aug 2026 19:22:05 +0000 Subject: dmaengine: fix use-after-free in dma_chan_put() and dma_release_channel() When dma_device_put() drops the last reference on chan->device->ref, dma_device_release() runs and may free the dma_device along with its channels. dma_chan_put() then still reads chan->device->owner via dma_chan_to_owner() for the trailing module_put(). KASAN catches it: slab-use-after-free in dma_chan_put+0x3e6/0x4c0 Read of size 8 by task insmod/6319 Freed by task 6319: kfree+0x225/0x470 dma_chan_put+0x395/0x4c0 dmaengine_put+0xf8/0x160 Cache the module owner in dma_chan_put() before the put so the trailing module_put() does not need chan->device. Fixes: 8ad342a86359 ("dmaengine: Add reference counting to dma_device struct") Suggested-by: Sashiko Link: https://sashiko.dev/#/patchset/20260518-dmaengine-kref-fix-v1-1-4d6125048fb7@amd.com Reviewed-by: Frank Li Reviewed-by: Logan Gunthorpe Signed-off-by: Shivank Garg Link: https://patch.msgid.link/20260822-dmaengine-kref-fix-v5-3-d4a4ee47d927@amd.com Signed-off-by: Vinod Koul --- drivers/video/fbdev/bt455.h | 90 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 drivers/video/fbdev/bt455.h (limited to 'drivers/video/fbdev/bt455.h') diff --git a/drivers/video/fbdev/bt455.h b/drivers/video/fbdev/bt455.h new file mode 100644 index 000000000..dd1404b40 --- /dev/null +++ b/drivers/video/fbdev/bt455.h @@ -0,0 +1,90 @@ +/* + * linux/drivers/video/bt455.h + * + * Copyright 2003 Thiemo Seufer + * Copyright 2016 Maciej W. Rozycki + * + * This file is subject to the terms and conditions of the GNU General + * Public License. See the file COPYING in the main directory of this + * archive for more details. + */ +#include + +/* + * Bt455 byte-wide registers, 32-bit aligned. + */ +struct bt455_regs { + volatile u8 addr_cmap; + u8 pad0[3]; + volatile u8 addr_cmap_data; + u8 pad1[3]; + volatile u8 addr_clr; + u8 pad2[3]; + volatile u8 addr_ovly; + u8 pad3[3]; +}; + +static inline void bt455_select_reg(struct bt455_regs *regs, int ir) +{ + mb(); + regs->addr_cmap = ir & 0x0f; +} + +static inline void bt455_reset_reg(struct bt455_regs *regs) +{ + mb(); + regs->addr_clr = 0; +} + +/* + * Read/write to a Bt455 color map register. + */ +static inline void bt455_read_cmap_next(struct bt455_regs *regs, u8 *grey) +{ + mb(); + regs->addr_cmap_data; + rmb(); + *grey = regs->addr_cmap_data & 0xf; + rmb(); + regs->addr_cmap_data; +} + +static inline void bt455_write_cmap_next(struct bt455_regs *regs, u8 grey) +{ + wmb(); + regs->addr_cmap_data = 0x0; + wmb(); + regs->addr_cmap_data = grey & 0xf; + wmb(); + regs->addr_cmap_data = 0x0; +} + +static inline void bt455_write_ovly_next(struct bt455_regs *regs, u8 grey) +{ + wmb(); + regs->addr_ovly = 0x0; + wmb(); + regs->addr_ovly = grey & 0xf; + wmb(); + regs->addr_ovly = 0x0; +} + +static inline void bt455_read_cmap_entry(struct bt455_regs *regs, + int cr, u8 *grey) +{ + bt455_select_reg(regs, cr); + bt455_read_cmap_next(regs, grey); +} + +static inline void bt455_write_cmap_entry(struct bt455_regs *regs, + int cr, u8 grey) +{ + bt455_select_reg(regs, cr); + bt455_write_cmap_next(regs, grey); +} + +static inline void bt455_write_ovly_entry(struct bt455_regs *regs, u8 grey) +{ + bt455_reset_reg(regs); + bt455_write_ovly_next(regs, grey); +} -- cgit v1.3.1